Make the pre-push script work on directories with spaces #105853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a secondary benefit, it's also a lot simpler.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
jyn514
commented
Dec 17, 2022
|
|
||
| cd "$ROOT_DIR" | ||
|
|
||
| $COMMAND | ||
| ./x test tidy |
There was a problem hiding this comment.
This is already in a .sh file, so we know there must be a shell available.
There was a problem hiding this comment.
can you just run a python script like this?
edit: TIL
rustbot
added
T-bootstrap
This comment has been minimized.
This comment has been minimized.
jyn514
force-pushed
the
prepush-windows
branch
from
aa089a4 to
c754d05
Compare
|
r=me |
Mark-Simulacrum
added
S-waiting-on-author
|
Thanks! @bors r+ rollup (pre-push script isn't tested in CI) |
bors
added
S-waiting-on-bors
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this pull request
Dec 23, 2022
Make the pre-push script work on directories with spaces As a secondary benefit, it's also a lot simpler. cc `@caass` - would love to have a review if you have time :)
|
@bors r=Mark-Simulacrum |
|
💡 This pull request was already approved, no need to approve it again.
|
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 23, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#105661 (implement the skeleton of the updated trait solver) - rust-lang#105853 (Make the pre-push script work on directories with spaces) - rust-lang#106043 (Move tests) - rust-lang#106048 (Run `tidy` in its own job in PR CI) - rust-lang#106055 (Check arg expressions properly on error in `confirm_builtin_call`) - rust-lang#106067 (A few metadata nits) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a secondary benefit, it's also a lot simpler.
cc @caass - would love to have a review if you have time :)